Cherry-picking 'Call super.onRequestPermissionsResult in ReactActivity (#42478)' onto 0.71 #42662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
cc @hurali97 |
hurali97
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I'm cherry-picking 96ed119 on the release branch for 0.71.
This change allows activities to handle onRequestPermissionsResult callbacks (eg: registerForActivityResult)
Fixes #42403
Changelog:
[Android][Changed] - Call super.onRequestPermissionsResult in ReactActivity's onRequestPermissionsResult()
Pull Request resolved: #42478
Test Plan:
Without super.onRequestPermissionsResult() call
With super.onRequestPermissionsResult() call